Remove restriction on file extension for some parsers #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem -------- All files are now run through the matches? method, which is causing issues for the lcov, gcov, and simplecov parsers since the matches? method checks that files have a particular file extension. This is causing failures when users pass a custom file. Solution -------- Always return true for the matches? method for lcov, gcov, and simplecov parsers. If the user does not specify a custom file, then only files that match the extensions listed in this method will be returned anyway due to the globs method. If a user specifies a custom file, we do not want to exclude the file just because it does not have the correct extension.
Pull Request Test Coverage Report for Build 9196041165Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
All files are now run through a parser's
matches?method, which is causing issues for the lcov,
gcov, and simplecov parsers since the
matches?method checks that files have aparticular file extension. This is causing failures
when users pass a custom file.
Solution
The lcov, gcov, and simplecov parsers were moved
to the last in the array of parsers, since they are
the only parsers which do not check actual
file contents to see if a file is of the correct
format. In order to ensure that these three
parsers will not erroneously match on files of
the other two types, we modify the
matches?method to return false if file extensions of the
other two parsers are matched.
If a user is passing a custom gcov, simplecov, or
lcov parser with a non-standard file extension, then
they must specify the
--formatparameter.If the user does not specify a custom file, then
only files that match the extensions formerly listed
in the
matches?method will be returned anywaydue to the
globsmethod.Closes #127