Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update coverage.py parser" #120

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Revert "Update coverage.py parser" #120

merged 1 commit into from
Apr 10, 2024

Conversation

littleforest
Copy link
Contributor

@littleforest littleforest commented Apr 9, 2024 •
edited
Loading

Reverts #116

This is causing an issue when a user has an existing coverage.xml
file and .coverage file but Coverage.py is not installed. Despite
having a coverage.xml file, the parser throws an error when
trying to convert .coverage to XML due to Coverage.py missing.

@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 8623314562

Details

  • 50 of 54 (92.59%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 93.719%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/coverage_reporter/parsers/coveragepy_parser.cr 50 54 92.59%
Files with Coverage Reduction New Missed Lines %
src/coverage_reporter/api/jobs.cr 1 97.92%
Totals Coverage Status
Change from base Build 8619630776: -0.2%
Covered Lines: 940
Relevant Lines: 1003
💛 - Coveralls

@littleforest littleforest requested a review from afinetooth April 9, 2024 23:00
@mike-burns mike-burns mentioned this pull request Apr 10, 2024
Closed
1 task
@mike-burns mike-burns merged commit 15f4e78 into master Apr 10, 2024
9 of 11 checks passed
@mike-burns mike-burns deleted the revert-116-coverage-py-xml-parse branch April 10, 2024 22:07
@littleforest littleforest mentioned this pull request Apr 16, 2024
Merged
@altaurog altaurog mentioned this pull request May 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-burns mike-burns mike-burns approved these changes

@afinetooth afinetooth Awaiting requested review from afinetooth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@littleforest @mike-burns