Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically retrieve the path to dumpbin.exe for windows build #118

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Dynamically retrieve the path to dumpbin.exe for windows build #118

merged 2 commits into from
Apr 9, 2024

Conversation

littleforest
Copy link
Contributor

@littleforest littleforest commented Apr 8, 2024 •
edited
Loading

This fixes the windows build by dynamically retrieving the path to dumpbin.exe.

@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Apr 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8607831254

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 93.952%
Totals Coverage Status
Change from base Build 8605119769: 0.1%
Covered Lines: 901
Relevant Lines: 959
💛 - Coveralls

@littleforest littleforest changed the title Try updating the visual studio version number Dynamically retrieve the path to dumpbin.exe for windows build Apr 8, 2024
@littleforest littleforest requested a review from afinetooth April 8, 2024 23:20
@littleforest littleforest marked this pull request as ready for review April 8, 2024 23:20
afinetooth
afinetooth approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@afinetooth afinetooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@littleforest littleforest merged commit 8d22630 into master Apr 9, 2024
11 checks passed
@littleforest littleforest deleted the windows-build-fix branch April 9, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afinetooth afinetooth afinetooth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@littleforest @afinetooth