fix(python): support python3.13 and drop python3.8 #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this fix |
dblanchette
pushed a commit
that referenced
this pull request
Nov 27, 2024
## [1.0.4](v1.0.3...v1.0.4) (2024-11-27) ### Bug Fixes * **python:** support python3.13 and drop python3.8 ([#273](#273)) ([063410e](063410e))
|
🎉 This PR is included in version 1.0.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion here I added the support for python3.13 by switching the lib from
htmlmintohtmlmin2.I also applied some changes:
npx prettier X --writeonCONTRIBUTING.md&README.mdBtw, I also find this library to minify the file wilsonzlin/minify-html but I got two issue, some tests was broken (got html when None was injected maybe there is an option to avoid making the input valid, and also the installation of the package which took some time).