Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(quantic): Exposed clearFilters option in quantic searchboxes #4606

Merged
merged 12 commits into from
Nov 5, 2024

Conversation

SimonMilord
Copy link
Contributor

@SimonMilord SimonMilord commented Oct 29, 2024

SFINT-5785

IN THIS PR:

  • Added the keepFiltersOnSearch properties on the quanticSearchBox and quanticStandaloneSearchBox that defaults to false (since clearFilters is enabled by default). Setting this to true makes it possible to not clear the facets after triggering a search (see demo below)
  • Added unit tests for when keepFiltersOnSearch is true/false

DEMO:

Screen.Recording.2024-10-28.at.1.34.03.PM.mov

Copy link

github-actions bot commented Oct 29, 2024

Pull Request Report

PR Title

❌ Title should follow the conventional commit spec:
<type>(optional scope): <description>

Example: feat(headless): add result-list controller

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 236.7 236.7 0
commerce 341.3 341.3 0
search 412.5 412.5 0
insight 401.8 401.8 0
recommendation 249 249 0
ssr 406.2 406.2 0
ssr-commerce 353.6 353.6 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@SimonMilord SimonMilord marked this pull request as ready for review October 29, 2024 17:37
@SimonMilord SimonMilord requested a review from a team as a code owner October 29, 2024 17:37
@SimonMilord SimonMilord marked this pull request as draft October 30, 2024 13:35
@SimonMilord SimonMilord requested a review from mmitiche October 30, 2024 17:08
@SimonMilord SimonMilord marked this pull request as ready for review October 30, 2024 17:08
Copy link
Contributor

@mmitiche mmitiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job 👍

couple more comments and there is the following issue that's occurring with the unit tests of the standalone search box that need to be fixed: https://github.com/coveo/ui-kit/actions/runs/11598185613/job/32293878598?pr=4606

Screenshot 2024-10-31 at 8 44 30 AM

@SimonMilord
Copy link
Contributor Author

good job 👍

couple more comments and there is the following issue that's occurring with the unit tests of the standalone search box that need to be fixed: https://github.com/coveo/ui-kit/actions/runs/11598185613/job/32293878598?pr=4606

Screenshot 2024-10-31 at 8 44 30 AM

will mute the console error

@mmitiche
Copy link
Contributor

good job 👍
couple more comments and there is the following issue that's occurring with the unit tests of the standalone search box that need to be fixed: https://github.com/coveo/ui-kit/actions/runs/11598185613/job/32293878598?pr=4606
Screenshot 2024-10-31 at 8 44 30 AM

will mute the console error

It's important to figure out the WHY before muting or doing any actions. Because this did not appear with other tests, only with this one.

@SimonMilord
Copy link
Contributor Author

good job 👍
couple more comments and there is the following issue that's occurring with the unit tests of the standalone search box that need to be fixed: https://github.com/coveo/ui-kit/actions/runs/11598185613/job/32293878598?pr=4606
Screenshot 2024-10-31 at 8 44 30 AM

will mute the console error

It's important to figure out the WHY before muting or doing any actions. Because this did not appear with other tests, only with this one.

fixed that by mocking the getHeadlessConfiguration method

Copy link
Contributor

@mmitiche mmitiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link
Collaborator

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@SimonMilord SimonMilord added this pull request to the merge queue Nov 5, 2024
Merged via the queue into master with commit 8b2b75d Nov 5, 2024
98 checks passed
@SimonMilord SimonMilord deleted the SFINT-5785 branch November 5, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants