fix(headless)!: clean up deprecated feedback methods #4404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
mmitiche
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
mmitiche
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
mmitiche
requested review from
olamothe,
louis-bompart,
fbeaudoincoveo,
erocheleau,
SimonMilord and
jelmedini
mmitiche
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
erocheleau
reviewed
Sep 12, 2024
...s/headless/src/controllers/core/generated-answer/headless-searchapi-generated-answer.test.ts
Outdated
Show resolved
Hide resolved
mmitiche
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
approved these changes
Sep 13, 2024
fbeaudoincoveo
approved these changes
Sep 13, 2024
mmitiche
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
mmitiche
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
mmitiche
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
removed this pull request from the merge queue due to the queue being cleared
louis-bompart
changed the title
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
mmitiche
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fpbrault
pushed a commit
that referenced
this pull request
Sep 17, 2024
[SFINT-5585](https://coveord.atlassian.net/browse/SFINT-5585) - Updated `sendFeedback` method in the generated answer controllers to accept only GeneratedAnswerFeedbackV2, the latest feedback schema we created to represent a feedback. - Updated the analytic actions logGeneratedAnswerFeedback by remove the logic that checks between v1 and v2 and use only GeneratedAnswerFeedbackV2 type. - Removed logGeneratedAnswerDetailedFeedback analytics action, as it is no longer used. - Renamed the type `GeneratedAnswerFeedbackV2` to `GeneratedAnswerFeedback` [SFINT-5585]: https://coveord.atlassian.net/browse/SFINT-5585?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Louis Bompart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SFINT-5585
sendFeedbackmethod in the generated answer controllers to accept only GeneratedAnswerFeedbackV2, the latest feedback schema we created to represent a feedback.GeneratedAnswerFeedbackV2toGeneratedAnswerFeedback