feat(quantic)!: Change names of DOM Events used, to add the 'quantic__' prefix #4383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request ReportPR Title❌ Title should follow the conventional commit spec: Example: Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
SimonMilord
changed the title
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
erocheleau
requested changes
Sep 11, 2024
packages/quantic/force-app/examples/main/lwc/actionAddFacets/actionAddFacets.js
Outdated
Show resolved
Hide resolved
...quantic/force-app/examples/main/lwc/exampleQuanticRefineToggle/exampleQuanticRefineToggle.js
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticCardContainer/quanticCardContainer.js
Show resolved
Hide resolved
...es/quantic/force-app/main/default/lwc/quanticCategoryFacetValue/quanticCategoryFacetValue.js
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticCitation/quanticCitation.js
Show resolved
Hide resolved
...ages/quantic/force-app/main/default/lwc/quanticRadioButtonsGroup/quanticRadioButtonsGroup.js
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticResultQuickview/quanticResultQuickview.js
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticStatefulButton/quanticStatefulButton.js
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticTabBar/quanticTabBar.js
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticTab/quanticTab.js
Outdated
Show resolved
Hide resolved
erocheleau
reviewed
Sep 11, 2024
packages/quantic/force-app/examples/main/lwc/actionSendRating/actionSendRating.js
Show resolved
Hide resolved
erocheleau
requested changes
Sep 11, 2024
SimonMilord
force-pushed
the
SFINT-5351
branch
from
e338511 to
2072e62
Compare
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
SimonMilord
force-pushed
the
SFINT-5351
branch
from
1b5b9f9 to
17c443c
Compare
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
mmitiche
reviewed
Sep 16, 2024
packages/quantic/force-app/main/default/lwc/quanticCardContainer/quanticCardContainer.js
Show resolved
Hide resolved
...es/quantic/force-app/main/default/lwc/quanticDocumentSuggestion/quanticDocumentSuggestion.js
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticFeedback/quanticFeedback.js
Outdated
Show resolved
Hide resolved
SimonMilord
force-pushed
the
SFINT-5351
branch
from
3a7e225 to
db98031
Compare
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
|
@SimonMilord Please address the conflicts and confirm that the E2E are all passing correctly ✅ |
SimonMilord
force-pushed
the
SFINT-5351
branch
from
dbdefdd to
5a32184
Compare
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
erocheleau
approved these changes
Sep 17, 2024
SimonMilord
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fpbrault
pushed a commit
that referenced
this pull request
Sep 17, 2024
…_' prefix (#4383) [SFINT-5351](https://coveord.atlassian.net/browse/SFINT-5351) ### IN THIS PR: Changed the prefix of custom DOM events in the quantic package to have the ‘quantic__’ prefix so that the naming convention is standard across the package. ### TESTS: <img width="884" alt="image" src="https://github.com/user-attachments/assets/f384d74f-1ce9-4172-8b1f-9a7a28e6dc47"> [SFINT-5351]: https://coveord.atlassian.net/browse/SFINT-5351?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SFINT-5351
IN THIS PR:
Changed the prefix of custom DOM events in the quantic package to have the ‘quantic__’ prefix so that the naming convention is standard across the package.
TESTS: