Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(atomic)!: remove gridCellLinkTarget property #4378

Merged
merged 8 commits into from
Sep 16, 2024
Merged

Conversation

fpbrault
Copy link
Contributor

@fpbrault fpbrault commented Sep 4, 2024

This PR removes the deprecated gridCellLinkTarget property

https://coveord.atlassian.net/browse/KIT-3487

Copy link

github-actions bot commented Sep 4, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 241 241 0
commerce 339.1 339.1 0
search 409.4 409.4 0
insight 392.7 392.7 0
product-recommendation 211.5 211.5 0
recommendation 252.5 252.5 0
ssr 402 402 0
ssr-commerce 351.3 351.3 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@fpbrault fpbrault marked this pull request as ready for review September 10, 2024 13:56
@fpbrault fpbrault requested review from a team as code owners September 10, 2024 13:56
@fpbrault fpbrault marked this pull request as draft September 10, 2024 13:57
@fpbrault fpbrault marked this pull request as ready for review September 10, 2024 17:09
@fpbrault fpbrault added this pull request to the merge queue Sep 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 11, 2024
@fpbrault fpbrault added this pull request to the merge queue Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2024
@fpbrault fpbrault added this pull request to the merge queue Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2024
@fpbrault fpbrault added this pull request to the merge queue Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2024
@fpbrault fpbrault added the v3 label Sep 13, 2024
@fpbrault fpbrault added this to the V3 milestone Sep 13, 2024
@louis-bompart louis-bompart self-assigned this Sep 16, 2024
@louis-bompart louis-bompart merged commit 4861e7d into master Sep 16, 2024
112 checks passed
@louis-bompart louis-bompart deleted the KIT-3487 branch September 16, 2024 22:52
fpbrault added a commit that referenced this pull request Sep 17, 2024
This PR removes the deprecated gridCellLinkTarget property

https://coveord.atlassian.net/browse/KIT-3487

---------

Co-authored-by: GitHub Actions Bot <>
Co-authored-by: Louis Bompart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants