Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: reenable tests disabled in #4294 #4306

Merged
merged 6 commits into from
Oct 28, 2024
Merged

ci: reenable tests disabled in #4294 #4306

merged 6 commits into from
Oct 28, 2024

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented Aug 21, 2024 •
edited by alexprudhomme
Loading

@louis-bompart louis-bompart requested review from a team as code owners August 21, 2024 17:08
@louis-bompart louis-bompart changed the title Revert "ci: temporarily disable some tests failing due to SAPI (#4294)" ci: reenable tests disabled in #4294 Aug 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 21, 2024 •
edited
Loading

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 236.6 236.6 0
commerce 341.5 341.5 0
search 412.3 412.3 0
insight 401.6 401.6 0
recommendation 248.8 248.8 0
ssr 406 406 0
ssr-commerce 353.6 353.6 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@louis-bompart louis-bompart added this pull request to the merge queue Aug 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 21, 2024
@louis-bompart louis-bompart force-pushed the reenable-skipped-test branch from d0fe0be to 2740cdf Compare August 22, 2024 13:06
@louis-bompart louis-bompart force-pushed the reenable-skipped-test branch from 6203697 to f42ad21 Compare August 26, 2024 18:58
@louis-bompart louis-bompart added this pull request to the merge queue Sep 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 6, 2024
@louis-bompart louis-bompart added this pull request to the merge queue Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 12, 2024
@louis-bompart louis-bompart force-pushed the reenable-skipped-test branch from 4703e07 to 3e92b8c Compare October 8, 2024 19:05
@louis-bompart louis-bompart enabled auto-merge (squash) October 8, 2024 19:05
@alexprudhomme alexprudhomme added this pull request to the merge queue Oct 28, 2024
Merged via the queue into master with commit ebf55db Oct 28, 2024
94 checks passed
@alexprudhomme alexprudhomme deleted the reenable-skipped-test branch October 28, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexprudhomme alexprudhomme alexprudhomme approved these changes

@y-lakhdar y-lakhdar y-lakhdar approved these changes

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/search

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@louis-bompart @y-lakhdar @alexprudhomme