Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade octokit graphql deps #3718

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented Mar 14, 2024

Octokit GraphQL pkgs moved to ESM, packages/quantic/scripts/build/create-package.ts is not ESM compatible
https://coveord.atlassian.net/browse/SFINT-5447

Copy link
Contributor

@mmitiche mmitiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was planing to tackle this with that: https://coveord.atlassian.net/browse/SFINT-5436
Thank you for addressing this 👌

Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 218.6 218.6 0
commerce 308.4 308.4 0
search 380.6 380.6 0
insight 345.2 345.2 0
product-listing 313.2 313.2 0
product-recommendation 185.9 185.9 0
recommendation 233 233 0
ssr 374.2 374.2 0

@louis-bompart louis-bompart enabled auto-merge March 14, 2024 19:02
@louis-bompart louis-bompart added this pull request to the merge queue Mar 14, 2024
Merged via the queue into master with commit 58472c6 Mar 14, 2024
90 checks passed
@louis-bompart louis-bompart deleted the lock-octokit-graphql branch March 14, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants