New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(commerce): add commerce category facets #3495

Merged

fbeaudoincoveo merged 67 commits into master from CAPI-90-category-facets

Mar 25, 2024

Contributor

fbeaudoincoveo commented Dec 19, 2023 •

edited

Loading

https://coveord.atlassian.net/browse/CAPI-90

Accompanying branch in barca: https://github.com/coveo/barca-sports/pull/191


          Add commerce category facets

7e30c35

fbeaudoincoveo requested a review from a team as a code owner

December 19, 2023 16:30

fbeaudoincoveo requested a review from Spuffynism

December 19, 2023 16:30

fbeaudoincoveo commented

View reviewed changes

...dless/src/controllers/commerce/facets/core/category/headless-commerce-category-facet.test.ts Outdated Show resolved Hide resolved

fbeaudoincoveo commented

View reviewed changes

...s/headless/src/controllers/commerce/facets/core/category/headless-commerce-category-facet.ts Outdated Show resolved Hide resolved

fbeaudoincoveo commented

View reviewed changes

packages/headless/src/controllers/commerce/facets/core/headless-core-commerce-facet.test.ts Outdated Show resolved Hide resolved

github-actions bot commented Dec 19, 2023 •

edited

Loading

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Bundle Size

File	Old (kb)	New (kb)	Change (%)
case-assist	197.8	197.8	0
commerce	242.2	244.7	1
search	355.6	355.6	0
insight	334.4	334.4	0
product-listing	252	252	0
product-recommendation	170.5	170.5	0
recommendation	212.7	212.7	0
ssr	349.7	349.7	0

fbeaudoincoveo commented

View reviewed changes

packages/headless/src/controllers/commerce/facets/core/headless-core-commerce-facet.test.ts Outdated Show resolved Hide resolved

fbeaudoincoveo commented

View reviewed changes

packages/headless/src/controllers/commerce/facets/core/headless-core-commerce-facet.ts Outdated Show resolved Hide resolved

fbeaudoincoveo commented

View reviewed changes

packages/headless/src/features/commerce/facets/facet-set/facet-set-actions.ts Outdated Show resolved Hide resolved

fbeaudoincoveo commented

View reviewed changes

packages/headless/src/features/commerce/facets/facet-set/facet-set-slice.test.ts Show resolved Hide resolved

fbeaudoincoveo commented

View reviewed changes

packages/headless/src/features/commerce/facets/facet-set/facet-set-slice.ts Outdated Show resolved Hide resolved

Spuffynism reviewed

View reviewed changes

...headless/src/controllers/commerce/facets/core/generator/headless-commerce-facet-generator.ts Outdated Show resolved Hide resolved

packages/headless/src/controllers/commerce/facets/core/headless-core-commerce-facet.ts Outdated Show resolved Hide resolved

packages/headless/src/controllers/commerce/facets/core/headless-core-commerce-facet.ts Outdated Show resolved Hide resolved

...adless/src/controllers/commerce/facets/core/utils/headless-core-commerce-facet-utils.test.ts Outdated Show resolved Hide resolved

...adless/src/controllers/commerce/facets/core/utils/headless-core-commerce-facet-utils.test.ts Outdated Show resolved Hide resolved

fbeaudoincoveo commented

View reviewed changes

...headless/src/controllers/commerce/facets/core/generator/headless-commerce-facet-generator.ts Outdated Show resolved Hide resolved

fbeaudoincoveo added 9 commits

December 19, 2023 14:22


          Apply review comments


          Add category facet exports

4770d4e


          Merge branch 'master' into CAPI-90-category-facets

86cf244


          Fix tests

0d78fd0


          Change behavior on invalid type + improve tests

3e39436


          Log errors with engine.logger

d2fed8e


          Fix typing issues

36d826e


          Move state-derived attributes out of state + rename type

53ca172


          Add selectedValueWithAncestry method + override state-derived methods

3925e1a

fbeaudoincoveo requested a review from a team as a code owner

December 22, 2023 15:46

fbeaudoincoveo requested review from y-lakhdar and louis-bompart

December 22, 2023 15:46

fbeaudoincoveo added 2 commits

December 22, 2023 11:49


          Update export name

1ddd44f


          Add support for deselecting all values in a given facet

bfe115a

fbeaudoincoveo commented

View reviewed changes

packages/headless/src/controllers/commerce/facets/core/headless-core-commerce-facet.ts Outdated Show resolved Hide resolved

louis-bompart reviewed

View reviewed changes

...headless/src/controllers/commerce/facets/core/generator/headless-commerce-facet-generator.ts Outdated Show resolved Hide resolved

packages/headless/src/controllers/commerce/facets/core/headless-core-commerce-facet.ts Outdated Show resolved Hide resolved

Spuffynism added 4 commits

March 5, 2024 09:37


          fix show more values condition

2ade722


          assert for no call

684e18e


          link jira to facet search todos

9943bba


          complete missing test

088d415

Spuffynism requested a review from louis-bompart

March 5, 2024 20:48


          switch to this jira

dfaecfa

Spuffynism reviewed

View reviewed changes

...dless/src/controllers/commerce/core/facets/category/headless-commerce-category-facet.test.ts Show resolved Hide resolved

Spuffynism added 2 commits

March 6, 2024 12:01


          Merge branch 'master' into CAPI-90-category-facets

7961baf


          Merge branch 'master' into CAPI-90-category-facets

5fa90da

Contributor

Spuffynism commented Mar 13, 2024

@louis-bompart @olamothe 👋 I'd love to get a review on this when you have the chance

olamothe approved these changes

View reviewed changes

packages/headless/src/features/commerce/facets/facet-set/facet-set-slice.ts Outdated Show resolved Hide resolved

packages/headless/src/controllers/commerce/core/facets/headless-core-commerce-facet.ts Show resolved Hide resolved

packages/headless/src/controllers/commerce/core/facets/headless-core-commerce-facet.ts Outdated Show resolved Hide resolved

packages/headless/src/controllers/commerce/core/facets/headless-core-commerce-facet.ts Outdated Show resolved Hide resolved

Spuffynism and others added 5 commits

March 13, 2024 13:22


          clean up controller

6dd9a47


          use default number of desired values

f63b6ee


          reflect that default value is used

4394c41


          Merge branch 'master' into CAPI-90-category-facets

8aa410a


          Merge branch 'master' into CAPI-90-category-facets

f86806c

louis-bompart approved these changes

View reviewed changes

fpbrault reviewed

View reviewed changes

...ess/src/controllers/commerce/core/facets/generator/headless-commerce-facet-generator.test.ts Show resolved Hide resolved

fbeaudoincoveo added 7 commits

March 20, 2024 12:03


          Merge branch 'master' into CAPI-90-category-facets

130be28


          Add delimiting character

52678c6


          Fix canShowLessValues


          Fix tests

49adaf5


          Add missing tests

d902a93


          Merge branch 'master' into CAPI-90-category-facets

ffbe270


          Merge branch 'master' into CAPI-90-category-facets

53038c9

Spuffynism approved these changes

View reviewed changes

fbeaudoincoveo added this pull request to the merge queue

Merged via the queue into master with commit 138a8b1

90 checks passed

fbeaudoincoveo deleted the CAPI-90-category-facets branch

March 25, 2024 15:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

fpbrault fpbrault left review comments

louis-bompart louis-bompart approved these changes

Spuffynism Spuffynism approved these changes

olamothe olamothe approved these changes

y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/search

Labels

None yet