-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(atomic): migrate to Tailwindcss v3 #1718
Conversation
Thanks for your contribution @ThibodeauJF !
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. Bundle Size
|
@@ -113,9 +113,9 @@ export const config: Config = { | |||
plugins: [ | |||
atImport(), | |||
mixins(), | |||
tailwindNesting(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to use tailwindcss/nesting
& put it before tailwind()
for it to work, we get errors in the other case, it's reusing postcss-nested
underneath.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this, we are getting an issue with mixins & nesting, the following doesn't work (same pattern as used in result templates):
/* Mixin with nesting */
@define-mixin test-mixin {
input {
background-color: red;
}
}
div {
@mixin test-mixin;
}
The fix is to reuse postcss-nested
a second time after tailwind()
like we did before. 🍔
"postcss-nested": "5.0.6", | ||
"puppeteer": "9.1.1", | ||
"react": "16.14.0", | ||
"rollup-plugin-html": "0.2.1" | ||
"rollup-plugin-html": "0.2.1", | ||
"tailwindcss": "3.0.19" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why it was a dependency ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, hum, I think it can indeed be seen as a dev dependency, because it's not actually "shipped" to our clients, like they won't actually download and install tailwind when they npm install @coveo/atomic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice !
"postcss-nested": "5.0.6", | ||
"puppeteer": "9.1.1", | ||
"react": "16.14.0", | ||
"rollup-plugin-html": "0.2.1" | ||
"rollup-plugin-html": "0.2.1", | ||
"tailwindcss": "3.0.19" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, hum, I think it can indeed be seen as a dev dependency, because it's not actually "shipped" to our clients, like they won't actually download and install tailwind when they npm install @coveo/atomic
https://coveord.atlassian.net/browse/KIT-1397
Followed https://tailwindcss.com/docs/upgrade-guide