Skip to content

Commit

Permalink
feat(headless): removed the triggeredBy from the insight analytics ac…
Browse files Browse the repository at this point in the history
…tions for logCreateArticle (#3484)

* updated coveo analytics to 2.28.24 and removed triggeredBy from insight analytics action payload for create article

* try something
  • Loading branch information
SimonMilord authored Dec 19, 2023
1 parent 0166932 commit 3074e55
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 9 deletions.
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/headless/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"@reduxjs/toolkit": "1.9.7",
"@types/redux-mock-store": "1.0.6",
"abab": "2.0.6",
"coveo.analytics": "2.28.23",
"coveo.analytics": "2.28.24",
"dayjs": "1.11.10",
"exponential-backoff": "3.1.0",
"fast-equals": "5.0.1",
Expand All @@ -68,8 +68,8 @@
"undici": "5.28.2"
},
"devDependencies": {
"@coveo/release": "1.0.0",
"@coveo/relay-event-types": "6.28.2",
"@coveo/release": "1.0.0",
"@microsoft/api-extractor": "7.38.5",
"@microsoft/api-extractor-model": "7.28.3",
"@microsoft/tsdoc": "0.14.2",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ const exampleCaseNumber = '5678';
const exampleOriginLevel2 = 'exampleOriginLevel2';
const exampleCreateArticleMetadata = {
articleType: 'Knowledge__kav',
triggeredBy: 'CreateArticleButton',
};

jest.mock('coveo.analytics', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import {InsightAction, makeInsightAnalyticsAction} from './analytics-utils';

export interface CreateArticleMetadata {
articleType: string;
triggeredBy: string;
}

export const logInsightInterfaceLoad = (): InsightAction =>
Expand All @@ -33,7 +32,6 @@ export const logInsightCreateArticle = (
(client, state) => {
validatePayload(createArticleMetadata, {
articleType: requiredNonEmptyString,
triggeredBy: requiredNonEmptyString,
});
return client.logCreateArticle(
createArticleMetadata,
Expand Down

0 comments on commit 3074e55

Please sign in to comment.