-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lineage notes standardization #2283
Lineage notes standardization #2283
Conversation
( B ) Standardized Issue Label Format Here are some suggestions. Currently we do both
But even an asymmetric standard could be adopted, such as:
|
When fixing ( G ), I discovered the usage of non-standard commas ( While the browsers Find functionality can locate this non-standard comma via the usage of a standard comma, Regex appears not able to parse the non-standard comma via the usage of a standard comma. Regex parse example. |
I committed the following standard. However, I can still be changed very easily now. I am doing an asymmetric standard where the main repo will be given the format This makes it slightly easier to distinguish between repos within lineage_notes. It is also the same format that AutoRef is using (as far as I am aware). |
@AngieHinrichs the JSON Check is passing now. Also, if this PR isn't wanted then it can be closed |
Thanks for all your work on this @ciscorucinski, and sorry it took me a while to give it a proper look. The non-standard comma character is 🤯 , I will look out for that in future PRs. And I agree with your choice of asymmetric issue number formatting. |
Source: #2280 (@RaphaelRaphael)
This PR should make it easier to view the existing changes and to allow for easier communication.
sars-cov-2-variants/lineage-proposals
changesFrom
/from
differencesAlias of
issuesxUSA
replacement issues@aviczhl2 I definitely need your input on ( B ) and ( C ) due to AutoRef.
CC @AngieHinrichs