Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lineage notes standardization #2283

Merged

Conversation

ciscorucinski
Copy link
Contributor

@ciscorucinski ciscorucinski commented Sep 15, 2023

Source: #2280 (@RaphaelRaphael)

This PR should make it easier to view the existing changes and to allow for easier communication.

  • ( A ) Reinstate sars-cov-2-variants/lineage-proposals changes
  • ( B ) Determine standardized issue label format
  • ( C ) Reinstate From/ from differences
  • ( D ) Fix issue label formats based on ( B )
  • ( E ) Fix Alias of issues
  • ( F ) Fix xUSA replacement issues
  • ( G ) Fix missing comma before issue label
  • ( H ) Fix issue labels not being last

@aviczhl2 I definitely need your input on ( B ) and ( C ) due to AutoRef.
CC @AngieHinrichs

@ciscorucinski
Copy link
Contributor Author

ciscorucinski commented Sep 15, 2023

( B ) Standardized Issue Label Format

Here are some suggestions. Currently we do both A and B along with a few others.

A B C
cov-lineages/pango-designation#xxx
sars-cov-2-variants/lineage-proposals#xxx
pango-designation issue #xxx
lineage-proposals issue #xxx
Something else?

A or the idea below are my choices

But even an asymmetric standard could be adopted, such as:

  • #xxx for all main repo issues
  • sars-cov-2-variants/lineage-proposals#xxx for 2nd repo issues

@ciscorucinski
Copy link
Contributor Author

When fixing ( G ), I discovered the usage of non-standard commas (). It is a single symbol that combines a comma and a space.

While the browsers Find functionality can locate this non-standard comma via the usage of a standard comma, Regex appears not able to parse the non-standard comma via the usage of a standard comma. Regex parse example.

@ciscorucinski
Copy link
Contributor Author

I committed the following standard. However, I can still be changed very easily now.

I am doing an asymmetric standard where the main repo will be given the format #xxx. The secondary repo will be given the format sars-cov-2-variants/lineage-proposals#xxx

This makes it slightly easier to distinguish between repos within lineage_notes. It is also the same format that AutoRef is using (as far as I am aware).

@ciscorucinski ciscorucinski marked this pull request as ready for review September 29, 2023 12:43
@ciscorucinski
Copy link
Contributor Author

@AngieHinrichs the JSON Check is passing now. Also, if this PR isn't wanted then it can be closed

@AngieHinrichs AngieHinrichs merged commit 4d6f729 into cov-lineages:master Oct 16, 2023
3 checks passed
@AngieHinrichs
Copy link
Member

Thanks for all your work on this @ciscorucinski, and sorry it took me a while to give it a proper look. The non-standard comma character is 🤯 , I will look out for that in future PRs. And I agree with your choice of asymmetric issue number formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants