-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sequences for 46 underrepresented Omicron lineages #1774
Merged
AngieHinrichs
merged 51 commits into
cov-lineages:master
from
AngieHinrichs:addSequences_2023-03-16
Mar 20, 2023
Merged
Add sequences for 46 underrepresented Omicron lineages #1774
AngieHinrichs
merged 51 commits into
cov-lineages:master
from
AngieHinrichs:addSequences_2023-03-16
Mar 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngieHinrichs
force-pushed
the
addSequences_2023-03-16
branch
from
March 20, 2023 20:19
1f9ee66
to
b487aa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that some important Omicron lineages have very few designated sequences, for example BQ.1.1 has only two designated sequences while the UShER tree has over 160000 BQ.1.1 sequences (excluding sublineages). BF.7.7 has only one designated sequence despite the UShER tree having over 1000 sequences on the BF.7.7 branch.
I ran a comparison of designated sequence counts (from lineages.csv) vs. UShER tree assignment counts for Omicron lineages and found 46 lineages with >100x fewer designated sequences than tree-assigned sequences. This PR adds randomly selected sequences from those 46 lineages from a quality-filtered tree (excluding sequences with two or more reversions relative to lineage root, and branches with a lot of mutations for few sequences (
matUtils extract --max-mutation-density 2
)) that are also found in a list of quality-filtered sequences from @InfrPopGen. Along the way I made several corrections to sequences already in lineages.csv:The scripts deduplicate_keeping_first.py and deduplicate_keeping_last.py were very handy for this, but they both add an extra blank line at the end of the rewritten lineages.csv so I fixed that in cb0eeb4.
There are still some lineages with >90x fewer designated sequences than big tree sequences, but this is already a lot of changes. Also, github is complaining about the size of lineages.csv, 74.9MB after this PR.
This exercise was also useful for finding several lineage annotations in the UShER tree that need to be shifted up or down by a node or three.