Skip to content
This repository has been archived by the owner on Apr 6, 2021. It is now read-only.

Also commit clade-defining SNPs? #10

Open
biocyberman opened this issue May 19, 2020 · 7 comments
Open

Also commit clade-defining SNPs? #10

biocyberman opened this issue May 19, 2020 · 7 comments

Comments

@biocyberman
Copy link

Hi @aineniamh
Could you also commit the clade defining SNPs output (defining_snps.csv) ? That will be helpful to see how each clade is defined at the sequence level. Besides regenerating from the alignment of representative sequences may introduce some discrepancies.

@aineniamh
Copy link
Member

HI @biocyberman, yes will do that. I'm starting to prepare the next data release and will make sure that's a part of the information in it.

@biocyberman
Copy link
Author

Would it be several days or more until the next release of data? In that case, it will be great if you could publish the defining snps for the current release (if you still have it).

@aineniamh
Copy link
Member

I'm doing it now, should be ready by tomorrow if that's soon enough. I think it's worth waiting for the new release as there are a couple of lineages flagged for removal.

@biocyberman
Copy link
Author

Perfect! I will wait.

@aineniamh
Copy link
Member

Hi @biocyberman, I've published the latest release. It took longer than expected, however am still sorting out some kinks in the lineage defining SNP assignment.

We're finding that (potentially due to homoplasies) there are still a couple of lineages without lineage defining SNPs being called, despite a branch with good support for the lineage existing. I'm fixing this as a priority, but wanted to get the new release out as soon as I could. I'll let you know when it's been fixed, thanks again for your patience.

@biocyberman
Copy link
Author

Really appreciate your effort @aineniamh

@rainwala
Copy link

rainwala commented Jun 22, 2020

Hello all, is this issue still being worked on? It's been a while since the last comment so I'm not sure. If it's available, if you could please point me to the lineage-defining SNP file? Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants