Make withScalaVersion also set Scala Binary Version in Complete #274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I don't know if this is intended, but I saw that:
Does not appear to also set the scala binary version (with the ultimate effect I don't get completions after
::
), I had a quick look in the coursier source and looks like it's because.withScalaVersionOpt(Option[String])
is used instead of.withScalaVersionOpt(Option[String], Boolean)
?Let me know if that makes sense, thanks ~ Laurence.