Removing test file overrides, specifying file names for failed hooks #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
jnwng
added a commit
that referenced
this pull request
Feb 12, 2016
Removing test file overrides, specifying file names for failed hooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tests failed within hooks (like beforeEach or afterEach), triple-latte would report "undefined" as the source, making it really difficult to track down errors. This will use the file from the test, and the file from the suite if we're inside a hook.
File information is already on the test object as of mochajs/mocha#950
Same with the test suites: mochajs/mocha@55f01bc
@eleith PTAL