rounded prop added #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
couds
requested changes
Jun 23, 2018
src/components/button/button.js
Outdated
| @@ -29,8 +31,9 @@ export default class Button extends PureComponent { | |||
| disabled: PropTypes.bool, | |||
| remove: PropTypes.bool, | |||
| isStatic: PropTypes.bool, | |||
| isRounded: PropTypes.bool, | |||
There was a problem hiding this comment.
Can you change the prop name to rounded the isStatic prop is an exception because static is a reserved word
LaRuaNa
force-pushed
the
button-is-rounded-fix
branch
from
b21775b to
eef04e9
Compare
couds
approved these changes
Jun 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #52
@couds i just realised that prettier changed the styling a bit. Is it a problem for you?