Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heading classNames mess #29

Closed
DimitarChristoff opened this issue May 14, 2018 · 0 comments
Closed

Heading classNames mess #29

DimitarChristoff opened this issue May 14, 2018 · 0 comments

Comments

@DimitarChristoff
Copy link
Contributor

Using <Heading> produces a <h1 class="title subtitle"> - the assertion is to check if heading is set and if not, adds class subtitle always.

https://github.com/couds/react-bulma-components/blob/master/src/components/heading/heading.js#L45-L46

adding heading={true} removes subtitle but also removes class title.

aim to me is to get <h1 class="title is-1"> by default - otherwise, if you have different stylings in bulma for title and subtitle, the subtitle colour is applied to your heading.

DimitarChristoff added a commit to DimitarChristoff/react-bulma-components that referenced this issue May 14, 2018
@couds couds closed this as completed in dd0126c May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant