-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CXXCBC-503: Ignore configuration if it contains an empty vBucketMap #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation ========== Server versions prior to 7.6.2 (MB-60405) can sometimes provide a configuration that has a vBucketMap, but it does not contain any vbuckets. This should not happend, but since it does the SDK should ignore these configurations. Changes ======= Ignore a configuration if it contains an empty vBucketMap.
avsej
approved these changes
Apr 9, 2024
avsej
added a commit
that referenced
this pull request
May 21, 2024
* origin/main: CXXCBC-407: allow to use 0 max expiry for new collections (#569) CXXCBC-445: return request_canceled on IO error in HTTP session (#568) CXXCBC-509: Zone-Aware replica reads (#566) CXXCBC-511: Prevent use of HTTP session if idle timer has expired (#565) Improve test stability (#563) Always attempt to extract common query code if error has not been set (#561) Add feature check for scoped analyze_document in tests (#555) CXXCBC-30 Inconsistent behaviour when using subdoc opcodes incorrectly (#559) CXXCBC-503 - Additions for more protection against picking up a config with an empty vbucket map. (#558) CXXCBC-503: Ignore configuration if it contains an empty vBucketMap (#556) CXXCBC-489: Add version_7_2_0 eventing function language compatibility (#554)
avsej
added a commit
that referenced
this pull request
May 21, 2024
* origin/main: CXXCBC-407: allow to use 0 max expiry for new collections (#569) CXXCBC-445: return request_canceled on IO error in HTTP session (#568) CXXCBC-509: Zone-Aware replica reads (#566) CXXCBC-511: Prevent use of HTTP session if idle timer has expired (#565) Improve test stability (#563) Always attempt to extract common query code if error has not been set (#561) Add feature check for scoped analyze_document in tests (#555) CXXCBC-30 Inconsistent behaviour when using subdoc opcodes incorrectly (#559) CXXCBC-503 - Additions for more protection against picking up a config with an empty vbucket map. (#558) CXXCBC-503: Ignore configuration if it contains an empty vBucketMap (#556) CXXCBC-489: Add version_7_2_0 eventing function language compatibility (#554)
avsej
added a commit
that referenced
this pull request
May 21, 2024
* origin/main: CXXCBC-407: allow to use 0 max expiry for new collections (#569) CXXCBC-445: return request_canceled on IO error in HTTP session (#568) CXXCBC-509: Zone-Aware replica reads (#566) CXXCBC-511: Prevent use of HTTP session if idle timer has expired (#565) Improve test stability (#563) Always attempt to extract common query code if error has not been set (#561) Add feature check for scoped analyze_document in tests (#555) CXXCBC-30 Inconsistent behaviour when using subdoc opcodes incorrectly (#559) CXXCBC-503 - Additions for more protection against picking up a config with an empty vbucket map. (#558) CXXCBC-503: Ignore configuration if it contains an empty vBucketMap (#556) CXXCBC-489: Add version_7_2_0 eventing function language compatibility (#554)
avsej
added a commit
that referenced
this pull request
May 21, 2024
* origin/main: CXXCBC-407: allow to use 0 max expiry for new collections (#569) CXXCBC-445: return request_canceled on IO error in HTTP session (#568) CXXCBC-509: Zone-Aware replica reads (#566) CXXCBC-511: Prevent use of HTTP session if idle timer has expired (#565) Improve test stability (#563) Always attempt to extract common query code if error has not been set (#561) Add feature check for scoped analyze_document in tests (#555) CXXCBC-30 Inconsistent behaviour when using subdoc opcodes incorrectly (#559) CXXCBC-503 - Additions for more protection against picking up a config with an empty vbucket map. (#558) CXXCBC-503: Ignore configuration if it contains an empty vBucketMap (#556) CXXCBC-489: Add version_7_2_0 eventing function language compatibility (#554)
avsej
added a commit
that referenced
this pull request
May 21, 2024
* origin/main: CXXCBC-407: allow to use 0 max expiry for new collections (#569) CXXCBC-445: return request_canceled on IO error in HTTP session (#568) CXXCBC-509: Zone-Aware replica reads (#566) CXXCBC-511: Prevent use of HTTP session if idle timer has expired (#565) Improve test stability (#563) Always attempt to extract common query code if error has not been set (#561) Add feature check for scoped analyze_document in tests (#555) CXXCBC-30 Inconsistent behaviour when using subdoc opcodes incorrectly (#559) CXXCBC-503 - Additions for more protection against picking up a config with an empty vbucket map. (#558) CXXCBC-503: Ignore configuration if it contains an empty vBucketMap (#556) CXXCBC-489: Add version_7_2_0 eventing function language compatibility (#554)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Server versions prior to 7.6.2 (MB-60405) can sometimes provide a configuration that has a vBucketMap, but it does not contain any vbuckets. This should not happend, but since it does the SDK should ignore these configurations.
Changes
Ignore a configuration if it contains an empty vBucketMap.