Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test stability #563

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Improve test stability #563

merged 2 commits into from
Apr 29, 2024

Conversation

avsej
Copy link
Member

@avsej avsej commented Apr 24, 2024

No description provided.

@avsej avsej force-pushed the tests-stability branch 9 times, most recently from 4223197 to 4817d94 Compare April 25, 2024 15:16
thejcfactor
thejcfactor previously approved these changes Apr 26, 2024
Copy link
Contributor

@thejcfactor thejcfactor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As these are tests, I don't think it blocks the review, but I did have a comment on some txns tests missing a potential skip if the server doesn't support txn queries. Otherwise LGTM 👍

test/test_transaction_simple.cxx Outdated Show resolved Hide resolved
test/utils/wait_until.cxx Show resolved Hide resolved
Copy link
Contributor

@thejcfactor thejcfactor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@avsej avsej merged commit 328520a into couchbase:main Apr 29, 2024
20 of 22 checks passed
@avsej avsej deleted the tests-stability branch April 29, 2024 17:13
avsej added a commit that referenced this pull request May 21, 2024
* origin/main:
  CXXCBC-407: allow to use 0 max expiry for new collections (#569)
  CXXCBC-445: return request_canceled on IO error in HTTP session (#568)
  CXXCBC-509: Zone-Aware replica reads (#566)
  CXXCBC-511: Prevent use of HTTP session if idle timer has expired (#565)
  Improve test stability (#563)
  Always attempt to extract common query code if error has not been set (#561)
  Add feature check for scoped analyze_document in tests (#555)
  CXXCBC-30 Inconsistent behaviour when using subdoc opcodes incorrectly (#559)
  CXXCBC-503 - Additions for more protection against picking up a config with an empty vbucket map. (#558)
  CXXCBC-503: Ignore configuration if it contains an empty vBucketMap (#556)
  CXXCBC-489: Add version_7_2_0 eventing function language compatibility (#554)
avsej added a commit that referenced this pull request May 21, 2024
* origin/main:
  CXXCBC-407: allow to use 0 max expiry for new collections (#569)
  CXXCBC-445: return request_canceled on IO error in HTTP session (#568)
  CXXCBC-509: Zone-Aware replica reads (#566)
  CXXCBC-511: Prevent use of HTTP session if idle timer has expired (#565)
  Improve test stability (#563)
  Always attempt to extract common query code if error has not been set (#561)
  Add feature check for scoped analyze_document in tests (#555)
  CXXCBC-30 Inconsistent behaviour when using subdoc opcodes incorrectly (#559)
  CXXCBC-503 - Additions for more protection against picking up a config with an empty vbucket map. (#558)
  CXXCBC-503: Ignore configuration if it contains an empty vBucketMap (#556)
  CXXCBC-489: Add version_7_2_0 eventing function language compatibility (#554)
avsej added a commit that referenced this pull request May 21, 2024
* origin/main:
  CXXCBC-407: allow to use 0 max expiry for new collections (#569)
  CXXCBC-445: return request_canceled on IO error in HTTP session (#568)
  CXXCBC-509: Zone-Aware replica reads (#566)
  CXXCBC-511: Prevent use of HTTP session if idle timer has expired (#565)
  Improve test stability (#563)
  Always attempt to extract common query code if error has not been set (#561)
  Add feature check for scoped analyze_document in tests (#555)
  CXXCBC-30 Inconsistent behaviour when using subdoc opcodes incorrectly (#559)
  CXXCBC-503 - Additions for more protection against picking up a config with an empty vbucket map. (#558)
  CXXCBC-503: Ignore configuration if it contains an empty vBucketMap (#556)
  CXXCBC-489: Add version_7_2_0 eventing function language compatibility (#554)
avsej added a commit that referenced this pull request May 21, 2024
* origin/main:
  CXXCBC-407: allow to use 0 max expiry for new collections (#569)
  CXXCBC-445: return request_canceled on IO error in HTTP session (#568)
  CXXCBC-509: Zone-Aware replica reads (#566)
  CXXCBC-511: Prevent use of HTTP session if idle timer has expired (#565)
  Improve test stability (#563)
  Always attempt to extract common query code if error has not been set (#561)
  Add feature check for scoped analyze_document in tests (#555)
  CXXCBC-30 Inconsistent behaviour when using subdoc opcodes incorrectly (#559)
  CXXCBC-503 - Additions for more protection against picking up a config with an empty vbucket map. (#558)
  CXXCBC-503: Ignore configuration if it contains an empty vBucketMap (#556)
  CXXCBC-489: Add version_7_2_0 eventing function language compatibility (#554)
avsej added a commit that referenced this pull request May 21, 2024
* origin/main:
  CXXCBC-407: allow to use 0 max expiry for new collections (#569)
  CXXCBC-445: return request_canceled on IO error in HTTP session (#568)
  CXXCBC-509: Zone-Aware replica reads (#566)
  CXXCBC-511: Prevent use of HTTP session if idle timer has expired (#565)
  Improve test stability (#563)
  Always attempt to extract common query code if error has not been set (#561)
  Add feature check for scoped analyze_document in tests (#555)
  CXXCBC-30 Inconsistent behaviour when using subdoc opcodes incorrectly (#559)
  CXXCBC-503 - Additions for more protection against picking up a config with an empty vbucket map. (#558)
  CXXCBC-503: Ignore configuration if it contains an empty vBucketMap (#556)
  CXXCBC-489: Add version_7_2_0 eventing function language compatibility (#554)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants