Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBG-4116 skip successful auth on silent handlers #7017

Merged
merged 1 commit into from
Jul 29, 2024
Merged

CBG-4116 skip successful auth on silent handlers #7017

merged 1 commit into from
Jul 29, 2024

Conversation

torcolvin
Copy link
Collaborator

@torcolvin torcolvin commented Jul 26, 2024

  • Report an authentication failed event if no credentials are specified on the admin port
  • /_ping endpoint uses publicPrivs so it doesn't log auth event anyway.

Tentatively removing

if !base.UnitTestUrlIsWalrus() {
		t.Skip("This test can panic with gocb logging CBG-4076")
}

but I should possibly pull that out into a separate commit. Without removing this, the test doesn't work! I'm not sure that we have a way to use rosmar with admin auth. I'm trying to reproduce CBG-4076 again.

I have a separate commit that makes all loggers work on an atomic.

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

@torcolvin torcolvin merged commit dedf99f into main Jul 29, 2024
38 checks passed
@torcolvin torcolvin deleted the CBG-4116 branch July 29, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants