CBG-4010 make FileLogger.Close shut down its own goroutines #6919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- close the rotation gorountines when closing the file logger
bbrks
approved these changes
Jun 26, 2024
|
Thank you! |
torcolvin
added a commit
that referenced
this pull request
Jul 3, 2024
- close the rotation gorountines when closing the file logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This failure happens reasonably often in github and is reproduce on mac with high -count numbers after ~20 or so tries. This makes closing the logger slower, but we are only doing this in test so I think the wait time is OK.