CBG-4019 Add init_in_progress property to db and verbose all_dbs responses #6910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torcolvin
reviewed
Jun 24, 2024
There was a problem hiding this comment.
API docs need to be updated:
sync_gateway/docs/api/components/schemas.yaml
Line 2526 in 9737474
| require.Equal(t, expectedValue, dbSummary.InitializationActive) | ||
| } | ||
| } | ||
| require.True(t, dbFound, "Database not found in _all_dbs response") |
There was a problem hiding this comment.
Suggested change
| require.True(t, dbFound, "Database not found in _all_dbs response") | |
| require.True(t, dbFound, "Database not found in _all_dbs response %+v", allDbResult) |
torcolvin
reviewed
Jun 24, 2024
rest/api.go
Outdated
| Bucket string `json:"bucket"` | ||
| State string `json:"state"` | ||
| InitializationActive bool `json:"init_in_progress,omitempty"` | ||
| Reason string `json:"reason,omitempty"` |
There was a problem hiding this comment.
Did you plan to change Reason to RequireResync in this PR? This was only in 3.1.7 and Isaac said it was fine to change this before rollout.
Redocly previews |
torcolvin
previously approved these changes
Jun 24, 2024
torcolvin
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBG-4019
Adds
init_in_progressflag to REST API db status calls when async index initialization is in progress.Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2529/