Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBG-3921 use IsDocNotFoundError everywhere #6828

Merged
merged 2 commits into from
May 17, 2024
Merged

CBG-3921 use IsDocNotFoundError everywhere #6828

merged 2 commits into from
May 17, 2024

Conversation

torcolvin
Copy link
Collaborator

@torcolvin torcolvin commented May 15, 2024

  • switch IsKeyNotFoundError and IsError(sgbucket.KeyNotFoundError)
  • slightly modify the behavior of IsDocNotFoundError to account for errors that might be wrapped without being the lowest level error.

couchbase/sg-bucket#126
couchbaselabs/rosmar#35

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Dependencies (if applicable)

  • Link upstream PRs
  • Update Go module dependencies when merged

Integration Tests

- switch IsKeyNotFoundError and IsError(sgbucket.KeyNotFoundError)
bbrks
bbrks previously approved these changes May 16, 2024
@torcolvin torcolvin merged commit cef73b7 into main May 17, 2024
32 checks passed
@torcolvin torcolvin deleted the CBG-3921 branch May 17, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants