Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBG-3914 change timeout to wait for authentication failure #6814

Merged
merged 2 commits into from
May 9, 2024

Conversation

torcolvin
Copy link
Collaborator

@torcolvin torcolvin commented May 8, 2024

gocb.Cluster.WaitForReady will perform the authentication handshake. If this goes slowly for some reason, it will return a timeout error instead of a gocb.ErrAuthenticationFailure

See https://jenkins.sgwdev.com/job/MasterIntegration/733/ for an example of this failure, but this fails a lot in MasterIntegration and weekly-jenkins runs.

I chose 15s as an arbitrary time. https://issues.couchbase.com/browse/MB-61174 contributes to the slowness, but this is from 7.6.0, 7.6.1 regression from 7.2 and the failure above comes from 7.2.3. I actually think we could increase this timeout.

This code behaved differently with gocouchbase buckets so I'm not sure how to 1:1 match the timeouts

func GetCouchbaseBucketGoCBFromAuthenticatedCluster(cluster *gocb.Cluster, spec BucketSpec, bucketPassword string) (bucket *CouchbaseBucketGoCB, err error) {

gocb.Cluster.WaitForReady will perform the authentication handshake. If
this goes slowly for some reason, it will return a timeout error instead
of a gocb.ErrAuthenticationFailure
@adamcfraser adamcfraser merged commit fa71403 into main May 9, 2024
30 checks passed
@adamcfraser adamcfraser deleted the CBG-3914 branch May 9, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants