CBG-3029 use matching regex replacement for go and python code #6710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbrks
approved these changes
Mar 5, 2024
gregns1
pushed a commit
that referenced
this pull request
Mar 6, 2024
torcolvin
added a commit
that referenced
this pull request
Mar 6, 2024
bbrks
pushed a commit
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
convert_to_valid_jsontoget_parsed_jsonwhich should match the behavior ofConvertBackQuotedStrings. At least tabs would not previously be handled correctly.Depending on tasks are used, the input to these functions is either a string (
make_curl_task) or bytes (add_file_task).The best thing that a reviewer can do is make sure
test_convert_to_valid_jsonis testing appropriate cases (lifted fromTestConvertBackQuotedStrings).Removed some unused functions/parameters unrelated to this, but showing that these exceptions do show in the log file of sgcollect: