Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Move OpenAPI commenting action to own workflow only for PRs #6684

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

bbrks
Copy link
Member

@bbrks bbrks commented Feb 14, 2024

Only leave preview links for OpenAPI spec changes made via PRs - not via pushed commits.

Avoids Not Found error in action when trying to find PR ID on non-PR commits.

ref: #6683

torcolvin
torcolvin previously approved these changes Feb 14, 2024
Copy link
Contributor

@gregns1 gregns1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@torcolvin torcolvin merged commit 9b78255 into master Feb 15, 2024
17 checks passed
@torcolvin torcolvin deleted the openapi-pr-workflow branch February 15, 2024 10:41
bbrks added a commit that referenced this pull request Mar 28, 2024
* Move OpenAPI commenting action to own workflow only for PRs

* Update .github/workflows/openapi-pr.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants