Speed up auth package tests by setting lower test-only bcrypt cost
#6682
+86
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregns1
approved these changes
Feb 13, 2024
| @@ -27,6 +27,11 @@ import ( | |||
| "gopkg.in/square/go-jose.v2/jwt" | |||
| ) | |||
|
|
|||
| func NewTestAuthenticator(t testing.TB, dataStore sgbucket.DataStore, channelComputer ChannelComputer, opts AuthenticatorOptions) *Authenticator { | |||
There was a problem hiding this comment.
Nitpick, but do we need t passed in here? Doesn't look to be used
There was a problem hiding this comment.
It's not used but added to prevent this function accidentally being moved and used in non-test code.
There was a problem hiding this comment.
Makes sense! Good shout! 😄
bbrks
added a commit
that referenced
this pull request
Mar 28, 2024
mohammed-madi
pushed a commit
that referenced
this pull request
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize most
authtests withNewTestAuthenticator, which lowers the bcrypt cost.Comparison
Integration Tests