Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow go mod tidy #6652

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Allow go mod tidy #6652

merged 2 commits into from
Jan 24, 2024

Conversation

torcolvin
Copy link
Collaborator

If you run go.mod tidy after 49f66ef, the go-ruleguard package would be deleted.

I declared this as an indirect dependency following best practice outlined here: golang/go#25922 (comment)

Copy link
Member

@bbrks bbrks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bbrks bbrks merged commit c0f8532 into master Jan 24, 2024
17 checks passed
@bbrks bbrks deleted the allow-go-mod-tidy branch January 24, 2024 10:53
bbrks pushed a commit that referenced this pull request Mar 28, 2024
* Run go.mod tidy

* Add tools file to prevent go-ruleguard from being declared an indirect depenency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants