implement body.Close checker #6646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamcfraser
previously approved these changes
Jan 17, 2024
bbrks
requested changes
Jan 18, 2024
rest/utilities_testing_user.go
Outdated
| @@ -37,6 +37,7 @@ func MakeUser(t *testing.T, httpClient *http.Client, serverURL, username, passwo | |||
| if err != nil { | |||
| return true, err, resp | |||
| } | |||
| assert.NoError(t, resp.Body.Close()) | |||
There was a problem hiding this comment.
Is it possible for the code outside the retry loop to read the body after it has already been closed? (47-51)
I think we can also drop the outer Body.Close() if we ensure the unclosed body doesn't leak out of the retry loop.
| @@ -2287,6 +2287,7 @@ func TestEventuallyReachableOIDCClient(t *testing.T) { | |||
| request := createOIDCRequest(t, sessionEndpoint, token) | |||
| response, err := http.DefaultClient.Do(request) | |||
| require.NoError(t, err, "Error sending request with bearer token") | |||
| defer func() { assert.NoError(t, response.Body.Close()) }() | |||
There was a problem hiding this comment.
Doesn't each response body need closing? The defer will only get one of the 3 here
bbrks
approved these changes
Jan 19, 2024
bbrks
pushed a commit
that referenced
this pull request
Mar 28, 2024
* implement body.Close * Add some missing asserts, simplify MakeUser * add missing error check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were no production code that was missing body.Close() but there was a lot missing in tests. This is a small resource leak.
Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiIntegration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2263/