CBG-3697 make sure on demand import errors show up as 404 #6637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The result of this is that blip will send a NoRev message since this revision is not accessible. - Delete validation in validateImportBody rather than change the type to report 404 since the only caller does not pass a nil pointer into this function.
adamcfraser
approved these changes
Jan 10, 2024
gregns1
pushed a commit
that referenced
this pull request
Feb 6, 2024
* write test * Change validation * CBG-3697 make sure on demand import errors show up as 404 - The result of this is that blip will send a NoRev message since this revision is not accessible. - Delete validation in validateImportBody rather than change the type to report 404 since the only caller does not pass a nil pointer into this function.
torcolvin
added a commit
that referenced
this pull request
Feb 6, 2024
…ed correctly (#6670) * CBG-3697 make sure on demand import errors show up as 404 (#6637) * write test * Change validation * CBG-3697 make sure on demand import errors show up as 404 - The result of this is that blip will send a NoRev message since this revision is not accessible. - Delete validation in validateImportBody rather than change the type to report 404 since the only caller does not pass a nil pointer into this function. * CBG-3697 skip test without xattrs (#6649) * updates to remove btcrunner on test --------- Co-authored-by: Tor Colvin <[email protected]>
bbrks
pushed a commit
that referenced
this pull request
Mar 28, 2024
* write test * Change validation * CBG-3697 make sure on demand import errors show up as 404 - The result of this is that blip will send a NoRev message since this revision is not accessible. - Delete validation in validateImportBody rather than change the type to report 404 since the only caller does not pass a nil pointer into this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of this is that blip will send a NoRev message since this
revision is not accessible.
Delete validation in validateImportBody rather than change the type to
report 404 since the only caller does not pass a nil pointer into this
function.
Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiIntegration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2252/