Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBG-3513: flaky test fix for TestCorruptDbConfigHandling #6616

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Conversation

gregns1
Copy link
Contributor

@gregns1 gregns1 commented Dec 15, 2023

CBG-3513

The underlying issue was the config update interval was way too frequently creating a race between adding the invalid db config the test adds to the bucket and the overwrite of that config. Top combat this I added the following:

  • Much higher config interval, essentially it is disabled of the test
  • A function for the test to manually fetch configs from bucket, so no more replying on the interval (to stop racy behaviour in the test)
  • A retry loop for fetching active database on the server context to assert on (after fixing the config), this was due to sometimes the test going too fast for the new updated/fixed db config to become 'active' on the server context.

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

@torcolvin torcolvin self-assigned this Dec 15, 2023
@torcolvin torcolvin enabled auto-merge (squash) December 15, 2023 17:56
@torcolvin torcolvin merged commit defab57 into master Dec 15, 2023
29 of 30 checks passed
@torcolvin torcolvin deleted the CBG-3513 branch December 15, 2023 18:11
bbrks pushed a commit that referenced this pull request Mar 28, 2024
* CBG-3513: flaky test fix for TestCorruptDbConfigHandling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants