Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBG-3637: Stat definitions use a named object for each stat definition #6592

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

IsaacLambat
Copy link
Member

CBG-3637

Each stat has its own named object instead of having the name as a field in the object. Labels are also now ordered.

Example:

	"sgw_replication_sgr_deltas_sent": {
		"labels": [
			"database",
			"replication"
		],
		"help": "The total number of deltas sent.",
		"added": "3.0.0",
		"stability": "committed",
		"type": "counter"
	},
	"sgw_replication_sgr_docs_checked_recv": {
		"labels": [
			"database",
			"replication"
		],
		"help": "The total number of document changes received over changes message.",
		"added": "3.0.0",
		"stability": "committed",
		"type": "counter"
	},
	"sgw_replication_sgr_docs_checked_sent": {
		"labels": [
			"database",
			"replication"
		],
		"help": "The total number of documents checked for changes since replication started. This represents the number of potential change notifications pushed by Sync Gateway. This is not necessarily the number of documents pushed, as a given target might already have the change and this is used by Inter-Sync Gateway and SG Replicate. This metric can be useful when analyzing replication history, and to filter by active replications.",
		"added": "3.0.0",
		"stability": "committed",
		"type": "counter"
	},
	"sgw_replication_sgr_num_attachment_bytes_pulled": {
		"unit": "bytes",
		"labels": [
			"database",
			"replication"
		],
		"help": "The total number of bytes in all the attachments that were pulled since replication started.",
		"added": "3.0.0",
		"stability": "committed",
		"type": "counter"
	},

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

@IsaacLambat IsaacLambat merged commit 91db64f into master Nov 30, 2023
26 checks passed
@IsaacLambat IsaacLambat deleted the CBG-3637 branch November 30, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants