Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-3615 escape sequence keyword in N1QL #6586

Merged
merged 2 commits into from
Nov 29, 2023
Merged

CBG-3615 escape sequence keyword in N1QL #6586

merged 2 commits into from
Nov 29, 2023

Conversation

torcolvin
Copy link
Collaborator

Escape sequence keyword in N1QL on creation. Any existing indexes pre server 7.6 are stored in an escaped fashion, so we only need to fix this for new index creation.

Created a way to use docker images from pre-release images in start_server.sh

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

@torcolvin
CBG-3615 Escape sequence keyword, pass tests with 7.6
a27e082 
- for integration tests, allow non dockerhub images if you specify a
  path
@torcolvin
use wildcard rather than regex
9c39d92
@torcolvin torcolvin requested a review from bbrks November 28, 2023 16:37
bbrks
bbrks approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@bbrks bbrks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@bbrks bbrks merged commit 4c00dba into master Nov 29, 2023
30 checks passed
@bbrks bbrks deleted the CBG-3615 branch November 29, 2023 12:03
bbrks pushed a commit that referenced this pull request Mar 28, 2024
@torcolvin @bbrks
CBG-3615 escape sequence keyword in N1QL (#6586)
d245c32 
* CBG-3615 Escape sequence keyword, pass tests with 7.6

- for integration tests, allow non dockerhub images if you specify a
  path

* use wildcard rather than regex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbrks bbrks bbrks approved these changes

Assignees

@bbrks bbrks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torcolvin @bbrks