Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-3253: Add CBMobileReplicationV4 #6583

Merged
merged 2 commits into from
Nov 24, 2023
Merged

CBG-3253: Add CBMobileReplicationV4 #6583

merged 2 commits into from
Nov 24, 2023

Conversation

bbrks
Copy link
Member

@bbrks bbrks commented Nov 24, 2023 •
edited
Loading

  • CBG-3253 Add subprotocol version v4 for VV/HLV
  • Actual Push/Pull changes will be done separately (CBG-3255 and CBG-3254)

Dependencies

Integration Tests

  • n/a

Base automatically changed from CBG-3253 to master November 24, 2023 17:27
adamcfraser
adamcfraser previously approved these changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@adamcfraser adamcfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V4 changes look fine, can merge once it's rebased on the dependency.

@bbrks bbrks force-pushed the CBG-3253-follow-up branch from 9637c60 to 7e542ad Compare November 24, 2023 17:37
@bbrks bbrks merged commit ad74e7e into master Nov 24, 2023
30 checks passed
@bbrks bbrks deleted the CBG-3253-follow-up branch November 24, 2023 18:01
bbrks added a commit that referenced this pull request Mar 28, 2024
@bbrks
CBG-3253: Add CBMobileReplicationV4 (#6583)
a738bf5 
* Add CBMobileReplicationV4 const

* Ensure TestAllowedAttachments works with v4 replicator version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamcfraser adamcfraser adamcfraser left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbrks @adamcfraser