CBG-3585 log bucket and groupID during config search #6564
Conversation
|
Generally speaking logging groupID is redundant information, since a given node (and it's logs) is only associated with a single groupID per startup, and the groupID is logged at startup. Given the particular relevance of groupID to the registry I'm fine leaving it here for ease of use, but as a rule I still think we should omit. |
I alway felt groupID was redundant but it was present in other log lines in the same function. The important thing that was left out was the bucket. OTOH, if you are trying to debug issues here having groupID again is helpful. |
#6667) * CBG-3585 log bucket and groupID during config search (#6564) * Replace `%w` with `%s` inside log functions. Only `fmt.Errorf` supports `%w` (#6494) --------- Co-authored-by: Tor Colvin <[email protected]> Co-authored-by: Ben Brooks <[email protected]>
This makes it a bit more clear which bucket a config error might come from. I added groupID to these logs as well, since they are logged by some lines in these functions but not all.