Obey db scoped console logging when evaluating whether to log #6553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbrks
approved these changes
Oct 25, 2023
torcolvin
added a commit
that referenced
this pull request
Oct 31, 2023
bbrks
pushed a commit
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The guts of this fix are to pass context in
LogInfoEnabled,LogDebugEnabled,LogTraceEnabled.I don't believe this affects capella since it only hits if db scoped logging is a broader level than bootstrap console logging.
In the case of capella, the logging is:
So the only potential caller of this statement does not apply in
handler.goPre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/api