Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-3553 add bucket.Close() when opening the database #6546

Merged
merged 5 commits into from
Oct 23, 2023
Merged

CBG-3553 add bucket.Close() when opening the database #6546

merged 5 commits into from
Oct 23, 2023

Conversation

torcolvin
Copy link
Collaborator

@torcolvin torcolvin commented Oct 20, 2023 •
edited
Loading

  • add dbcontext.Close if there's a failure after dbContext is open
  • modify non persistent config PUT /db/ config code to return 500 to match error codes on error for persistent config (previously returned 400)

Integration Tests

@torcolvin torcolvin requested a review from adamcfraser October 20, 2023 20:12
@torcolvin
CBG-3553 add bucket.Close() when opening the database
6783d26 
- close the DatabaseContext if it's not managed by the database if it hasn't been added to
- changed newSequenceAllocator to not leak a goroutine
@torcolvin torcolvin changed the title CBG-3553 add bucket.Close() when opening the database [DO NOT MERGE] CBG-3553 add bucket.Close() when opening the database Oct 23, 2023
@torcolvin torcolvin changed the title [DO NOT MERGE] CBG-3553 add bucket.Close() when opening the database CBG-3553 add bucket.Close() when opening the database Oct 23, 2023
bbrks
bbrks requested changes Oct 23, 2023
View reviewed changes
Copy link
Member

@bbrks bbrks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with these changes.
Maybe one more that would've sped up the CBSE investigation?

db/sequence_allocator.go Outdated Show resolved Hide resolved
adamcfraser
adamcfraser requested changes Oct 23, 2023
View reviewed changes
rest/server_context.go Outdated Show resolved Hide resolved
adamcfraser
adamcfraser previously approved these changes Oct 23, 2023
View reviewed changes
@adamcfraser adamcfraser merged commit 5ef676e into master Oct 23, 2023
26 checks passed
@adamcfraser adamcfraser deleted the CBG-3553 branch October 23, 2023 21:16
torcolvin added a commit that referenced this pull request Oct 23, 2023
@torcolvin
CBG-3553 add bucket.Close() when opening the database (#6546)
3637c94 
* CBG-3553 add bucket.Close() when opening the database

- close the DatabaseContext if it's not managed by the database if it hasn't been added to
- changed newSequenceAllocator to not leak a goroutine

* Don't create db automatically

* Improve error message

* Don't close dbcontext if already registered

* Remove test which did not test anything
@torcolvin torcolvin mentioned this pull request Oct 23, 2023
Merged
adamcfraser pushed a commit that referenced this pull request Oct 23, 2023
@torcolvin
CBG-3553 add bucket.Close() when opening the database (#6546) (#6548)
f63068e 
* CBG-3553 add bucket.Close() when opening the database

- close the DatabaseContext if it's not managed by the database if it hasn't been added to
- changed newSequenceAllocator to not leak a goroutine

* Don't create db automatically

* Improve error message

* Don't close dbcontext if already registered

* Remove test which did not test anything
torcolvin added a commit that referenced this pull request Oct 31, 2023
@torcolvin
CBG-3553 add bucket.Close() when opening the database (#6546)
ce83f81 
* CBG-3553 add bucket.Close() when opening the database

- close the DatabaseContext if it's not managed by the database if it hasn't been added to
- changed newSequenceAllocator to not leak a goroutine

* Don't create db automatically

* Improve error message

* Don't close dbcontext if already registered

* Remove test which did not test anything
bbrks pushed a commit that referenced this pull request Mar 28, 2024
@torcolvin @bbrks
CBG-3553 add bucket.Close() when opening the database (#6546)
b159d78 
* CBG-3553 add bucket.Close() when opening the database

- close the DatabaseContext if it's not managed by the database if it hasn't been added to
- changed newSequenceAllocator to not leak a goroutine

* Don't create db automatically

* Improve error message

* Don't close dbcontext if already registered

* Remove test which did not test anything
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbrks bbrks bbrks requested changes

@adamcfraser adamcfraser adamcfraser left review comments

Assignees

@adamcfraser adamcfraser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@torcolvin @bbrks @adamcfraser