Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.1.2 Backport] Conditional logging for DocChanged based on collection #6519

Merged
merged 3 commits into from
Oct 13, 2023
Merged

[3.1.2 Backport] Conditional logging for DocChanged based on collection #6519

merged 3 commits into from
Oct 13, 2023

Conversation

bbrks
Copy link
Member

@bbrks bbrks commented Oct 11, 2023 •
edited by torcolvin
Loading

@adamcfraser
Copy link
Collaborator

adamcfraser commented Oct 11, 2023 •
edited
Loading

CI test failure looks unrelated to the backport, but going to sanity check the logging test errors in the integration run.

@torcolvin torcolvin self-assigned this Oct 13, 2023
@torcolvin
[3.1.2 backport] CBG-3518 flush the log buffers collateBuffer is enab…
5e8328b 
…led (#6523)

* CBG-3518 flush the log buffers collateBuffer is enabled
* Remove warning count assertion since warnings can come through from DCP mutations from previous tests
* Update the assertion to use testify contains
@torcolvin torcolvin assigned adamcfraser and unassigned torcolvin Oct 13, 2023
@adamcfraser adamcfraser merged commit 4c5ba22 into release/3.1.2 Oct 13, 2023
@adamcfraser adamcfraser deleted the CBG-3519 branch October 13, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamcfraser adamcfraser adamcfraser approved these changes

Assignees

@adamcfraser adamcfraser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bbrks @adamcfraser @torcolvin