CBG-3384 Avoid triggering unnecessary resync when working with default collection #6504
Conversation
| @@ -42,8 +42,12 @@ type BootstrapConnection interface { | |||
| // TouchMetadataDocument sets the specified property in a bootstrap metadata document for a given bucket and key. Used to | |||
| // trigger CAS update on the document, to block any racing updates. Does not retry on CAS failure. | |||
| TouchMetadataDocument(ctx context.Context, bucket, key string, property string, value string, cas uint64) (casOut uint64, err error) | |||
| // KeyExists checks whether the specified key exists | |||
| // KeyExists checks whether the specified key exists in the bucket's default collection | |||
There was a problem hiding this comment.
should we say metadata collection here and below for when we migrate this to a separate collection?
Right now default collection = metadata collection but it may not always.
There was a problem hiding this comment.
I intentionally left this comment as default collection because the bootstrap doesn't currently have the concept of a metadata store, and will require some refactoring when we want to add system collection support.
| } | ||
| return false, err | ||
| } | ||
| err = getResult.Content(rv) |
| @@ -397,6 +400,9 @@ func InitSyncInfo(ds DataStore, metadataID string) (requiresResync bool, err err | |||
|
|
|||
| // SetSyncInfo sets syncInfo in a DataStore to the specified metadataID | |||
| func SetSyncInfo(ds DataStore, metadataID string) error { | |||
| if metadataID == "" { | |||
There was a problem hiding this comment.
Can you drop a comment for why this happens here, for future reference?
| return standardMetadataID | ||
| } | ||
| if exists { | ||
| base.WarnfCtx(ctx, "Error checking syncInfo metadataID in default collection - using standard metadataID. Error: %v", err) |
There was a problem hiding this comment.
I haven't thoroughly thought this through, but is this going to be called only when there's a cas change, or is this going to log at bootstrap pooling interval?
There was a problem hiding this comment.
This is only going to be called once per db creation - once the metadataID is assigned (to standardMetadataID in this case), it won't fire again.
- Don’t persist syncInfo for empty metadataID (legacy config) - Modify requirements for assignment of default metadata ID to a database: 1. Remove requirement for presence of _sync:seq in default collection 2. Allow assignment when default collection’s syncInfo is using defaultMetadataID These avoid triggering resync for databases using only the default collection, in legacy and non-legacy mode.
If database already exists in registry, new databases (in different config groups) should use the same metadataID.
| var legacyConfig rest.LegacyServerConfig | ||
| err := base.JSONUnmarshal(legacyConfigBytes, &legacyConfig) | ||
| assert.NoError(t, err) | ||
| legacyRT.Close() |
There was a problem hiding this comment.
move this up to defer at the top of test to protect other tests?
There was a problem hiding this comment.
This needs to be closed before opening the non-legacy RTs, so leaving as-is.
…t collection (#6504) * CBG-3384 Modify computation of metadataID - Don’t persist syncInfo for empty metadataID (legacy config) - Modify requirements for assignment of default metadata ID to a database: 1. Remove requirement for presence of _sync:seq in default collection 2. Allow assignment when default collection’s syncInfo is using defaultMetadataID These avoid triggering resync for databases using only the default collection, in legacy and non-legacy mode. If database already exists in registry, new databases (in different config groups) should use the same metadataID.
…t collection (#6504) * CBG-3384 Modify computation of metadataID - Don’t persist syncInfo for empty metadataID (legacy config) - Modify requirements for assignment of default metadata ID to a database: 1. Remove requirement for presence of _sync:seq in default collection 2. Allow assignment when default collection’s syncInfo is using defaultMetadataID These avoid triggering resync for databases using only the default collection, in legacy and non-legacy mode. If database already exists in registry, new databases (in different config groups) should use the same metadataID.
CBG-3384
These avoid triggering resync for databases using only the default collection, in legacy and non-legacy mode.
Also ensures databases share metadataIDs across config groups (CBG-3527)
Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2111/