-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CBG-3467 add verbose mode for _all_dbs #6493
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - will leave for @JRascagneres to have final say/merge
Yeah think it looks fine, as you said a sort might be nice? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK but may want to consider sort.Slice
to avoid building the intermediate slice for sorting.
I expect this is an endpoint the UI will be polling on a very regular inteval like it does for /_resync
, etc.
Co-authored-by: Ben Brooks <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, minor docs suggestions.
Co-authored-by: Adam Fraser <[email protected]>
oneOf
to specify this - this is how it renders in redocly: https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/couchbase/sync_gateway/b62b000ed6cce3b069c8b3d1beafe1f0e40035c8/docs/api/admin.yaml#tag/Database-Management/operation/get__all_dbsPre-review checklist
fmt.Print
,log.Print
, ...)base.UD(docID)
,base.MD(dbName)
)docs/api