Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBG-3467 add verbose mode for _all_dbs #6493

Merged
merged 5 commits into from
Oct 5, 2023
Merged

CBG-3467 add verbose mode for _all_dbs #6493

merged 5 commits into from
Oct 5, 2023

Conversation

torcolvin
Copy link
Collaborator

@torcolvin torcolvin commented Oct 4, 2023

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

bbrks
bbrks previously approved these changes Oct 5, 2023
Copy link
Member

@bbrks bbrks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - will leave for @JRascagneres to have final say/merge

@JRascagneres
Copy link
Member

Yeah think it looks fine, as you said a sort might be nice?

bbrks
bbrks previously requested changes Oct 5, 2023
Copy link
Member

@bbrks bbrks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK but may want to consider sort.Slice to avoid building the intermediate slice for sorting.

I expect this is an endpoint the UI will be polling on a very regular inteval like it does for /_resync, etc.

rest/server_context.go Outdated Show resolved Hide resolved
@torcolvin torcolvin enabled auto-merge (squash) October 5, 2023 16:43
Copy link
Collaborator

@adamcfraser adamcfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor docs suggestions.

docs/api/components/schemas.yaml Outdated Show resolved Hide resolved
docs/api/paths/admin/_all_dbs.yaml Outdated Show resolved Hide resolved
Co-authored-by: Adam Fraser <[email protected]>
@adamcfraser adamcfraser dismissed bbrks’s stale review October 5, 2023 21:47

Comments have been addressed.

@torcolvin torcolvin merged commit cf8c3a4 into master Oct 5, 2023
@torcolvin torcolvin deleted the CBG-3467 branch October 5, 2023 21:47
torcolvin added a commit that referenced this pull request Oct 5, 2023
torcolvin added a commit that referenced this pull request Oct 5, 2023
torcolvin added a commit that referenced this pull request Oct 5, 2023
torcolvin added a commit that referenced this pull request Oct 6, 2023
torcolvin added a commit that referenced this pull request Oct 31, 2023
bbrks pushed a commit that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants