CBG-2579: TestReplicatorCheckpointOnStop test fix #6460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…suggested disabling the checkpoint interval which is not what the test is doing
bbrks
requested changes
Sep 25, 2023
bbrks
approved these changes
Sep 26, 2023
bbrks
pushed a commit
that referenced
this pull request
Mar 28, 2024
* CBG-2579: update to actually reduce the checkpoint interval. Comment suggested disabling the checkpoint interval which is not what the test is doing * updates to increase checkpoint interval * temp enable trace loging * updates to add trace logging to enable us to debug further * fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBG-2579
Not able to repro the failiure locally.
But the first thing that jumps out is that the test fails to fetch the persisted checkpoint, suggesting its simply not there. A comment in the test previously suggested setting the checkpoint interval to 0 is disabling the interval. This is incorrect, it will default to the default value in this context which is 5 seconds. See -> https://github.com/couchbase/sync_gateway/blob/ac740e85e06f965fff11a6f7972e8c8c56d6834b/db/active_replicator_common.go#L93C3-L93C3 I have now replaced this with
reduceTestCheckpointIntervalto increase the checkpoint frequency and 50 seconds. Hopefully will stop the test from flaking.Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiIntegration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2036/