[3.1.2 backport] CBG-3426 perform a length check on raw xattr bytes #6449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* CBG-3238 perform a length check on raw bytes - refactor attachment compaction tests so we can make sure that it doesn't terminate * Add comment * remove redundant returns * Move error handling into getAttachmentSyncData * PR fixup - remove attachment compaction changes and leave only a change to avoid failure to mark changes if xattr length is invalid. Treat this as a document without xattrs in order to not fail attachment compaction test. - add code to prevent overflow if xattr len is a number between 1-4 which would cause a panic. * Update tests * remove test tested in separate function
bbrks
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backports: CBG-3238 perform a length check on raw bytes (#6438)