CBG-3277 add a stat for mismatched bucket names in dbconfigs #6410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamcfraser
requested changes
Sep 12, 2023
API call is happening - fix a race where the invalid status wouldn't get cleared: - config polling gets data - PUT config - log about config error / clear config error - this config wouldn't be re-read because it would CAS match - remove assertions to stats, because they are global and with a bucket pool, configs from previous tests will contaiminate the test harness
adamcfraser
requested changes
Sep 15, 2023
| @@ -3724,7 +3726,7 @@ func TestConfigsIncludeDefaults(t *testing.T) { | |||
| assert.Equal(t, db.DefaultChannelCacheMaxNumber, *runtimeServerConfigDatabase.CacheConfig.ChannelCacheConfig.MaxNumber) | |||
| assert.Equal(t, base.DefaultOldRevExpirySeconds, *runtimeServerConfigDatabase.OldRevExpirySeconds) | |||
| assert.Equal(t, false, *runtimeServerConfigDatabase.StartOffline) | |||
| assert.Equal(t, db.DefaultCompactInterval, uint32(*runtimeServerConfigDatabase.CompactIntervalDays)) | |||
| assert.Equal(t, db.DefaultCompactInterval, time.Duration(*runtimeServerConfigDatabase.CompactIntervalDays)*24*time.Hour) | |||
There was a problem hiding this comment.
Are we rebasing this to remove this change in this PR?
Co-authored-by: Adam Fraser <[email protected]>
adamcfraser
approved these changes
Sep 15, 2023
1 task
bbrks
pushed a commit
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some copypasta test assertions from previous commit.
Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiIntegration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2004/ (known issue, plus one fix from a previous commit that I forgot?)