Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-3285 fix DefaultDbConfig CompactIntervalDays #6409

Merged
merged 1 commit into from
Sep 11, 2023
Merged

CBG-3285 fix DefaultDbConfig CompactIntervalDays #6409

merged 1 commit into from
Sep 11, 2023

Conversation

torcolvin
Copy link
Collaborator

This amounts to a change that only affects test code, I think. Moved DefaultCompactInterval to a typed constant and wrote tests to make sure we round trip data correctly.

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

gregns1
gregns1 approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@gregns1 gregns1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@torcolvin torcolvin merged commit a5b25c3 into master Sep 11, 2023
26 checks passed
@torcolvin torcolvin deleted the CBG-3285 branch September 11, 2023 16:40
bbrks pushed a commit that referenced this pull request Mar 28, 2024
@torcolvin @bbrks
CBG-3285 fix DefaultDbConfig CompactIntervalDays (#6409)
c13ba0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregns1 gregns1 gregns1 approved these changes

Assignees

@gregns1 gregns1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torcolvin @gregns1