Make SubdocXattrStore work with Rosmar collections #6374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snej
force-pushed
the
rosmar-subdocXattrStore
branch
from
8fe6d00
to
af26892
Compare
torcolvin
reviewed
Aug 24, 2023
There was a problem hiding this comment.
Can you remove TestRequiresSubdocXattrStore https://github.com/couchbase/sync_gateway/blob/master/base/util_testing.go#L768
I think all the tests pass with SG_TEST_USE_XATTRS=false and SG_TEST_USE_XATTRS=true and this review?
Otherwise looks good, we'll just wait to merge until upstream go.mod hit the main branch.
* There's a new interface sgbucket.XattrStore2 that contains the methods of SubdocXattrStore that aren't redundant. * rosmar.Collection implements XattrStore2. * LeakyDataStore now implements SubdocXattrStore; the methods are either delegated to their existing DataStore counterparts, or to the new methods from XattrStore2. * AsSubdocXattrStore() isn't needed anymore, because LeakyDataStore now implements SubdocXattrStore.
snej
force-pushed
the
rosmar-subdocXattrStore
branch
from
af26892
to
09bc9fa
Compare
|
OK, removed it. Everything seems to work with and without xattrs enabled. |
torcolvin
approved these changes
Aug 31, 2023
bbrks
pushed a commit
that referenced
this pull request
Mar 28, 2024
* Make SubdocXattrStore work with Rosmar collections * There's a new interface sgbucket.XattrStore2 that contains the methods of SubdocXattrStore that aren't redundant. * rosmar.Collection implements XattrStore2. * LeakyDataStore now implements SubdocXattrStore; the methods are either delegated to their existing DataStore counterparts, or to the new methods from XattrStore2. * AsSubdocXattrStore() isn't needed anymore, because LeakyDataStore now implements SubdocXattrStore. * Removed obsolete TestRequiresSubdocXattrStore()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiDependencies (if applicable)
Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/000/