Take a copy of UserData without pointer-hacks that get optimised away (…

…#6175)
couchbase · Apr 11, 2023 · 3c7eca6 · 3c7eca6
1 parent 255397f
commit 3c7eca6
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/db/active_replicator.go b/db/active_replicator.go
@@ -269,7 +269,11 @@ func blipSync(target url.URL, blipContext *blip.Context, insecureSkipVerify bool
 	var basicAuthCreds *url.Userinfo
 	if target.User != nil {
 		// take a copy
-		basicAuthCreds = &*target.User
+		if password, hasPassword := target.User.Password(); hasPassword {
+			basicAuthCreds = url.UserPassword(target.User.Username(), password)
+		} else {
+			basicAuthCreds = url.User(target.User.Username())
+		}
 		target.User = nil
 	}