Skip to content

Commit

Permalink
put lint timeout in config (#6576)
Browse files Browse the repository at this point in the history
This means it is automatically picked up by editors in addition to CI.
Usually this is fast, but sometimes staticcheck can slow down,
especially on mac. Once it is cached, it is quick.

Updated golangci-lint version in github actions.
  • Loading branch information
torcolvin authored Nov 14, 2023
1 parent 8fd554e commit 1db1763
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ jobs:
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
version: v1.55.0
args: --config=.golangci-strict.yml --timeout=3m
version: v1.55.2
args: --config=.golangci-strict.yml

test:
runs-on: ${{ matrix.os }}
Expand Down
2 changes: 2 additions & 0 deletions .golangci-strict.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

# config file for golangci-lint

timeout: 3m

linters:
enable:
#- bodyclose # checks whether HTTP response body is closed successfully
Expand Down
2 changes: 2 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

# config file for golangci-lint

timeout: 3m

linters:
enable:
- bodyclose # checks whether HTTP response body is closed successfully
Expand Down

0 comments on commit 1db1763

Please sign in to comment.